[
https://issues.apache.org/jira/browse/MINIFICPP-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568445#comment-16568445
]
ASF GitHub Bot commented on MINIFICPP-583:
------------------------------------------
GitHub user phrocker opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/387
MINIFICPP-583: Allow Expression language to compile if CURL is disabl…
…ed while also honoring the request to disable CURL functionality
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/phrocker/nifi-minifi-cpp MINIFICPP-583
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/387.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #387
----
commit da511de3ec5ac25bf4bdd587bdc85e22966263c3
Author: Marc Parisi <phrocker@...>
Date: 2018-08-03T16:31:21Z
MINIFICPP-583: Allow Expression language to compile if CURL is disabled
while also honoring the request to disable CURL functionality
----
> Cannot disable curl properly
> ----------------------------
>
> Key: MINIFICPP-583
> URL: https://issues.apache.org/jira/browse/MINIFICPP-583
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Mr TheSegfault
> Priority: Blocker
> Fix For: 0.6.0
>
>
> Build fails with curl disabled due to civet always being enabled. We should
> more intelligently allow this to be disabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
