Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/388#discussion_r208026845
  
    --- Diff: extensions/pcap/CapturePacket.cpp ---
    @@ -54,13 +54,15 @@ namespace processors {
     std::shared_ptr<utils::IdGenerator> CapturePacket::id_generator_ = 
utils::IdGenerator::getIdGenerator();
     core::Property CapturePacket::BaseDir("Base Directory", "Scratch directory 
for PCAP files", "/tmp/");
     core::Property CapturePacket::BatchSize("Batch Size", "The number of 
packets to combine within a given PCAP", "50");
    +core::Property CapturePacket::NetworkControllers("Network Controllers", 
"List of network controllers to attach to -- each may be a regex", ".*");
    --- End diff --
    
    This is meant to convey a YAML list ( 
https://docs.ansible.com/ansible/latest/reference_appendices/YAMLSyntax.html ), 
however as this isn't intended to be YAML specific I will clarify this. I 
thought about making it dynamic but did not see great value. Do you think this 
should be dynamic?


---

Reply via email to