[
https://issues.apache.org/jira/browse/MINIFICPP-590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570831#comment-16570831
]
ASF GitHub Bot commented on MINIFICPP-590:
------------------------------------------
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/388#discussion_r208041393
--- Diff: extensions/pcap/CapturePacket.cpp ---
@@ -54,13 +54,15 @@ namespace processors {
std::shared_ptr<utils::IdGenerator> CapturePacket::id_generator_ =
utils::IdGenerator::getIdGenerator();
core::Property CapturePacket::BaseDir("Base Directory", "Scratch directory
for PCAP files", "/tmp/");
core::Property CapturePacket::BatchSize("Batch Size", "The number of
packets to combine within a given PCAP", "50");
+core::Property CapturePacket::NetworkControllers("Network Controllers",
"List of network controllers to attach to -- each may be a regex", ".*");
--- End diff --
I would agree that dynamic doesn't really seem like the right fit and
arguably a misuse of what they are supposed to represent. The clarification is
definitely helpful though concerning the expectation of the YAML list.
Admittedly this comment stemmed from my NiFI leaning perspective where all
property values are inherently just strings
> Resolve zero length flow files at startup of pcap processor.
> -------------------------------------------------------------
>
> Key: MINIFICPP-590
> URL: https://issues.apache.org/jira/browse/MINIFICPP-590
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Mr TheSegfault
> Assignee: Mr TheSegfault
> Priority: Major
> Attachments: Screen Shot 2018-08-03 at 1.56.42 PM.png
>
>
> Batching feature in PCAP appears to break at some points. Investigate this.
> May be a memory issue on certain versions of GCC
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
