[
https://issues.apache.org/jira/browse/NIFI-5535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Corey Fritz updated NIFI-5535:
------------------------------
Description:
The current (and looks like original) implementation of the
DataDogReportingTask is not applying metric tags correctly, and as a result,
the "Environment" configuration property on that task does not work. This means
that you're not going to be able to use tags to differentiate the metric values
coming from different environments.
Currently, every metric reported by this task gets the same set of tags applied:
{code:java}
connection-destination-id
connection-destination-name
connection-group-id
connection-id
connection-name
connection-source-id
connection-source-name
dataflow_id
env
port-group-id
port-id
port-name{code}
This list is defined here:
[https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/metrics/MetricsService.java#L111-L126]
I've attached a screenshot from Datadog demonstrating a JVM metric with all of
these tags applied.
Each of these tags should include a value, i.e. "env:dev" instead of just "env".
Other observations:
* it doesn't make sense to attach the _connection-*_ and _port-*_ tags to JVM
metrics
* I'm not sure I see any value in the _dataflow_id_ tag
I was hoping for a quick fix when I noticed the environment tagging wasn't
working, but after reviewing the code I think a not insignificant refactoring
will be required. I'll try to tackle this if/when time allows.
See here for more context on Datadog tagging:
[https://docs.datadoghq.com/tagging]
was:
The current (and looks like original) implementation of the
DataDogReportingTask is not applying metric tags correctly, and as a result,
the "Environment" configuration property on that task does not work. This means
that you're not going to be able to use tags to differentiate the metric values
coming from different environments.
Currently, every metric reported by this task gets the same set of tags applied:
{code:java}
connection-destination-id
connection-destination-name
connection-group-id
connection-id
connection-name
connection-source-id
connection-source-name
dataflow_id
env
port-group-id
port-id
port-name{code}
This list is defined here:
[https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/metrics/MetricsService.java#L111-L126]
I've attached a screenshot from Datadog demonstrating a JVM metric with all of
these tags applied.
Each of these tags should include a value, i.e. "env:dev" instead of just "env".
Other observations:
* it doesn't make sense to attach the _connection-**_ and _port-_ tags to JVM
metrics
* I'm not sure I see any value in the _dataflow_id_ tag
I was hoping for a quick fix when I noticed the environment tagging wasn't
working, but after reviewing the code I think a not insignificant refactoring
will be required. I'll try to tackle this if/when time allows.
See here for more context on Datadog tagging:
[https://docs.datadoghq.com/tagging]
> DataDogReportingTask is not tagging metrics properly
> ----------------------------------------------------
>
> Key: NIFI-5535
> URL: https://issues.apache.org/jira/browse/NIFI-5535
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.7.1
> Reporter: Corey Fritz
> Priority: Major
>
> The current (and looks like original) implementation of the
> DataDogReportingTask is not applying metric tags correctly, and as a result,
> the "Environment" configuration property on that task does not work. This
> means that you're not going to be able to use tags to differentiate the
> metric values coming from different environments.
> Currently, every metric reported by this task gets the same set of tags
> applied:
> {code:java}
> connection-destination-id
> connection-destination-name
> connection-group-id
> connection-id
> connection-name
> connection-source-id
> connection-source-name
> dataflow_id
> env
> port-group-id
> port-id
> port-name{code}
> This list is defined here:
> [https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-datadog-bundle/nifi-datadog-reporting-task/src/main/java/org/apache/nifi/reporting/datadog/metrics/MetricsService.java#L111-L126]
> I've attached a screenshot from Datadog demonstrating a JVM metric with all
> of these tags applied.
> Each of these tags should include a value, i.e. "env:dev" instead of just
> "env".
> Other observations:
> * it doesn't make sense to attach the _connection-*_ and _port-*_ tags to
> JVM metrics
> * I'm not sure I see any value in the _dataflow_id_ tag
> I was hoping for a quick fix when I noticed the environment tagging wasn't
> working, but after reviewing the code I think a not insignificant refactoring
> will be required. I'll try to tackle this if/when time allows.
> See here for more context on Datadog tagging:
> [https://docs.datadoghq.com/tagging]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
