[
https://issues.apache.org/jira/browse/NIFI-5553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16591988#comment-16591988
]
ASF GitHub Bot commented on NIFI-5553:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2967
NIFI-5553: Fixed issue with rollback on result set errors
Set the w=1 parameter on this URL to ignore whitespace changes (I indented
a bunch of code to put it in a try/catch) and see the actual changes.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5553
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2967.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2967
----
commit 219fb80be8d1b87efd2e3f75a45366a87dc3802d
Author: Matthew Burgess <mattyb149@...>
Date: 2018-08-24T17:56:32Z
NIFI-5553: Fixed issue with rollback on result set errors
----
> ExecuteSQL incorrectly causes session rollback rather than routing to failure
> -----------------------------------------------------------------------------
>
> Key: NIFI-5553
> URL: https://issues.apache.org/jira/browse/NIFI-5553
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> If ExecuteSQL has an incoming connection and the query executes successfully,
> then if an error occurs while processing the result set(s), the session
> incorrectly gets rolled back, when the expected behavior is to route the
> incoming flow file to failure.
> After the query executes successfully, a flow file is created to contain the
> result set.If an exception occurs after this, the original incoming flow file
> is correctly transferred to failure, but the result set flow file has not
> been removed. This causes the session to rollback and thus return the
> incoming flow file to the incoming queue.
> This has been verified as a bug in NiFi 1.5.0 and the current master
> (1.8.0-SNAPSHOT) but is working as expected in NiFi 1.2.0. I suspect this may
> have been introduced by NIFI-3432, in any case a unit test should be added to
> prevent regressions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
