[ 
https://issues.apache.org/jira/browse/NIFI-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16593952#comment-16593952
 ] 

ASF GitHub Bot commented on NIFI-4371:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2138#discussion_r213045384
  
    --- Diff: 
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/nifi/processors/hive/AbstractHive3QLProcessor.java
 ---
    @@ -345,4 +348,22 @@ private void findTableNames(final Object obj, final 
Set<TableName> tableNames) {
             }
             return attributes;
         }
    +
    +    /**
    +     * Method to set the configured timeout on the statement to be executed
    +     * @param stmt statement to be executed
    +     * @param context process context to retrieve the configured value
    +     * @param flowFile flow file to evaluate expression language
    +     * @throws ProcessException exception in case configured value cannot 
be converted to an integer
    +     */
    +    protected void setTimeout(Statement stmt, ProcessContext context, 
FlowFile flowFile) throws ProcessException {
    --- End diff --
    
    Should we have a customValidate() for this like you added for 
AbstractHiveQLProcessor?


> Add support for query timeout in Hive processors
> ------------------------------------------------
>
>                 Key: NIFI-4371
>                 URL: https://issues.apache.org/jira/browse/NIFI-4371
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>            Priority: Major
>         Attachments: Screen Shot 2017-09-09 at 4.31.21 PM.png, Screen Shot 
> 2017-09-09 at 6.38.51 PM.png, Screen Shot 2017-09-09 at 6.40.48 PM.png
>
>
> With HIVE-4924 it is possible to set a query timeout when executing a query 
> against Hive (starting with Hive 2.1). Right now, NiFi is built using Hive 
> 1.2.1 and this feature is not available by default (the method is not 
> implemented in the driver). However, if building NiFi with specific profiles 
> this feature can be used.
> The objective is to expose the query timeout parameter in the processor and 
> enable expression language. If the version of the driver is not implementing 
> the query timeout the processor will be in invalid state (unless expression 
> language is used, and in this case, the flow file will be routed to the 
> failure relationship).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to