[ 
https://issues.apache.org/jira/browse/NIFI-5561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597157#comment-16597157
 ] 

ASF GitHub Bot commented on NIFI-5561:
--------------------------------------

Github user pvillard31 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2973#discussion_r213933052
  
    --- Diff: 
nifi-nar-bundles/nifi-extension-utils/nifi-reporting-utils/src/main/java/org/apache/nifi/reporting/util/provenance/ProvenanceEventConsumer.java
 ---
    @@ -241,20 +255,24 @@ private long updateLastEventId(final 
List<ProvenanceEventRecord> events, final S
     
         private boolean isFilteringEnabled() {
             return componentTypeRegex != null || !eventTypes.isEmpty() || 
!componentIds.isEmpty()
    -                || componentTypeRegexExclude != null || 
!eventTypesExclude.isEmpty() || !componentIdsExclude.isEmpty();
    +                || componentTypeRegexExclude != null || 
!eventTypesExclude.isEmpty() || !componentIdsExclude.isEmpty()
    +                || componentNameRegex != null || componentNameRegexExclude 
!= null;
    --- End diff --
    
    Yeah agree, I added your two commits on this pull request. Thanks!


> Add component name filtering to S2S Provenance Reporting Task
> -------------------------------------------------------------
>
>                 Key: NIFI-5561
>                 URL: https://issues.apache.org/jira/browse/NIFI-5561
>             Project: Apache NiFi
>          Issue Type: Improvement
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>            Priority: Major
>
> I'd like to add component name as a way to filter events sent by the 
> SiteToSite Provenance Reporting task so that, for example, all events 
> generated by components containing "Prov" in the name are picked.
> This will be much easier to manage rather than component IDs as the ID of a 
> component could change when a workflow is promoted from one environment to 
> another in a CI/CD pipeline.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to