[
https://issues.apache.org/jira/browse/NIFI-5239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602157#comment-16602157
]
ASF GitHub Bot commented on NIFI-5239:
--------------------------------------
Github user zenfenan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2896#discussion_r214684778
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java
---
@@ -244,22 +266,20 @@ public final void closeClient() {
}
}
- protected MongoDatabase getDatabase(final ProcessContext context) {
- return getDatabase(context, null);
- }
+// protected MongoDatabase getDatabase(final ProcessContext context) {
+// return getDatabase(context, null);
+// }
protected MongoDatabase getDatabase(final ProcessContext context,
final FlowFile flowFile) {
final String databaseName =
context.getProperty(DATABASE_NAME).evaluateAttributeExpressions(flowFile).getValue();
- if (StringUtils.isEmpty(databaseName)) {
- throw new ProcessException("Database name was empty after
expression language evaluation.");
- }
- return mongoClient.getDatabase(databaseName);
- }
- protected MongoCollection<Document> getCollection(final ProcessContext
context) {
- return getCollection(context, null);
+ return clientService!= null ?
clientService.getDatabase(databaseName) : mongoClient.getDatabase(databaseName);
}
+// protected MongoCollection<Document> getCollection(final
ProcessContext context) {
+// return getCollection(context, null);
+// }
+
--- End diff --
Same here.
> Make MongoDBControllerService able to act as a configuration source for
> MongoDB processors
> ------------------------------------------------------------------------------------------
>
> Key: NIFI-5239
> URL: https://issues.apache.org/jira/browse/NIFI-5239
> Project: Apache NiFi
> Issue Type: New Feature
> Reporter: Mike Thomsen
> Assignee: Mike Thomsen
> Priority: Major
>
> The MongoDBControllerService should be able to provide the getDatabase and
> getCollection functionality that are built into the MongoDB processors
> through AbstractMongoDBProcessor. Using the controller service with the
> processors should be optional in the first release it's added and then
> mandatory going forward.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
