[
https://issues.apache.org/jira/browse/NIFI-5147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16602955#comment-16602955
]
ASF GitHub Bot commented on NIFI-5147:
--------------------------------------
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2980#discussion_r214882758
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/security/util/crypto/HashAlgorithm.java
---
@@ -0,0 +1,151 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.security.util.crypto;
+
+import java.util.Arrays;
+import java.util.List;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.lang3.builder.ToStringBuilder;
+import org.apache.commons.lang3.builder.ToStringStyle;
+
+/**
+ * Enumeration capturing information about the cryptographic hash
algorithms used in
+ * {@link org.apache.nifi.processors.standard.CalculateAttributeHash} and
+ * {@link org.apache.nifi.processors.standard.HashContent} processors.
+ */
+public enum HashAlgorithm {
+
+ MD2("MD2", 16, "Cryptographically broken due to collisions"),
+ MD5("MD5", 16, "Cryptographically broken due to collisions"),
+ SHA1("SHA-1", 20, "Cryptographically broken due to collisions"),
+ SHA224("SHA-224", 28, "SHA-2 family"),
+ SHA256("SHA-256", 32, "SHA-2 family"),
+ SHA384("SHA-384", 48, "SHA-2 family"),
+ SHA512("SHA-512", 64, "SHA-2 family"),
+ SHA512_224("SHA-512/224", 28, "SHA-2 using SHA-512 with truncated
output"),
+ SHA512_256("SHA-512/256", 32, "SHA-2 using SHA-512 with truncated
output"),
+ SHA3_224("SHA3-224", 28, "Keccak-based SHA3 family"),
+ SHA3_256("SHA3-256", 32, "Keccak-based SHA3 family"),
+ SHA3_384("SHA3-384", 48, "Keccak-based SHA3 family"),
+ SHA3_512("SHA3-512", 64, "Keccak-based SHA3 family"),
+ BLAKE2_160("BLAKE2-160", 20, "Also known as Blake2b"),
+ BLAKE2_256("BLAKE2-256", 32, "Also known as Blake2b"),
+ BLAKE2_384("BLAKE2-384", 48, "Also known as Blake2b"),
+ BLAKE2_512("BLAKE2-512", 64, "Also known as Blake2b");
+
+ private final String name;
+ private final int digestBytesLength;
+ private final String description;
+
+ private static final List<String> BROKEN_ALGORITHMS =
Arrays.asList(MD2.name, MD5.name, SHA1.name);
+
+ HashAlgorithm(String name, int digestBytesLength, String description) {
+ this.name = name;
+ this.digestBytesLength = digestBytesLength;
+ this.description = description;
+ }
+
+ public String getName() {
+ return name;
+ }
+
+ public int getDigestBytesLength() {
+ return digestBytesLength;
+ }
+
+ public String getDescription() {
+ return description;
+ }
+
+ /**
+ * Returns {@code true} if this algorithm is considered
cryptographically secure. These determinations were made as of 2018-08-30.
+ *
+ * Current strong algorithms:
+ *
+ * * SHA-224 (SHA2)
+ * * SHA-256 (SHA2)
+ * * SHA-384 (SHA2)
+ * * SHA-512 (SHA2)
+ * * SHA-512/224 (SHA2)
+ * * SHA-512/256 (SHA2)
+ * * SHA3-256
+ * * SHA3-384
+ * * SHA3-512
+ * * Blake2b-256
+ * * Blake2b-384
+ * * Blake2b-512
+ *
+ * Current broken algorithms:
+ *
+ * * MD2
+ * * MD5
+ * * SHA-1
+ *
+ * @return true if the algorithm is considered strong
+ */
+ public boolean isStrongAlgorithm() {
+ return (!BROKEN_ALGORITHMS.contains(name));
+ }
+
--- End diff --
What is the isBlake2 check about? Is there a way to make it more general?
It seems strange to call out by the name as opposed to the "why"
> Improve HashAttribute processor
> -------------------------------
>
> Key: NIFI-5147
> URL: https://issues.apache.org/jira/browse/NIFI-5147
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.6.0
> Reporter: Andy LoPresto
> Assignee: Otto Fowler
> Priority: Major
> Labels: hash, security
> Fix For: 1.8.0
>
>
> The {{HashAttribute}} processor currently has surprising behavior. Barring
> familiarity with the processor, a user would expect {{HashAttribute}} to
> generate a hash value over one or more attributes. Instead, the processor as
> it is implemented "groups" incoming flowfiles into groups based on regular
> expressions which match attribute values, and then generates a
> (non-configurable) MD5 hash over the concatenation of the matching attribute
> keys and values.
> In addition:
> * the processor throws an error and routes to failure any incoming flowfile
> which does not have all attributes specified in the processor
> * the use of MD5 is vastly deprecated
> * no other hash algorithms are available
> I am unaware of community use of this processor, but I do not want to break
> backward compatibility. I propose the following steps:
> * Implement a new {{CalculateAttributeHash}} processor (awkward name, but
> this processor already has the desired name)
> ** This processor will perform the "standard" use case -- identify an
> attribute, calculate the specified hash over the value, and write it to an
> output attribute
> ** This processor will have a required property descriptor allowing a
> dropdown menu of valid hash algorithms
> ** This processor will accept arbitrary dynamic properties identifying the
> attributes to be hashed as a key, and the resulting attribute name as a value
> ** Example: I want to generate a SHA-512 hash on the attribute {{username}},
> and a flowfile enters the processor with {{username}} value {{alopresto}}. I
> configure {{algorithm}} with {{SHA-512}} and add a dynamic property
> {{username}} -- {{username_SHA512}}. The resulting flowfile will have
> attribute {{username_SHA512}} with value
> {{739b4f6722fb5de20125751c7a1a358b2a7eb8f07e530e4bf18561fbff93234908aa9d2577770c876bca9ede5ba784d5ce6081dbbdfe5ddd446678f223b8d632}}
> * Improve the documentation of this processor to explain the goal/expected
> use case (?)
> * Link in processor documentation to new processor for standard use cases
> * Remove the error alert when an incoming flowfile does not contain all
> expected attributes. I propose changing the severity to INFO and still
> routing to failure
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
