[
https://issues.apache.org/jira/browse/NIFI-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603310#comment-16603310
]
ASF GitHub Bot commented on NIFI-3425:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2986
NIFI-3425: Provide ability to cache CQL statements
Co-authored-by: Michael A Giroux
<[email protected]>
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [x] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-3425
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2986.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2986
----
commit bc32c49bacb736d621c32cbc479db9a09f61d3c6
Author: Matthew Burgess <mattyb149@...>
Date: 2018-09-04T16:51:52Z
NIFI-3425: Provide ability to cache CQL statements
Co-authored-by: Michael A Giroux
<[email protected]>
----
> Cache prepared statements in PutCassandraQL
> -------------------------------------------
>
> Key: NIFI-3425
> URL: https://issues.apache.org/jira/browse/NIFI-3425
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Minor
> Attachments: NIFI-3425.patch
>
>
> Currently PutCassandraQL supports prepared statements (using ? parameters
> much like JDBC SQL statements) via flow file attributes specifying the type
> and value of the parameters.
> However, the prepared statement is created (and thus possibly re-created) for
> each flow file, which neuters its effectiveness over literal CQL statements.
> The driver warns of this:
> 2017-01-31 14:30:54,287 WARN [cluster1-worker-1]
> com.datastax.driver.core.Cluster Re-preparing already prepared query insert
> into test_table (id, timestamp, id1, timestamp1, id
> 2, timestamp2, id3, timestamp3, id4, timestamp4, id5, timestamp5, id6,
> timestamp6) values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?);. Please note
> that preparing the same query
> more than once is generally an anti-pattern and will likely affect
> performance. Consider preparing the statement only once.
> Prepared statements should be cached and reused where possible.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
