Github user jtstorck commented on the issue:
https://github.com/apache/nifi/pull/2988
Regarding this PR, on my Windows 7 desktop, the NiFiGroovyTest in
nifi-runtime passes:
```
[INFO] -------------------------------------------------------
[INFO] T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.apache.nifi.NiFiGroovyTest
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
2.103 s - in org.apache.nifi.NiFiGroovyTest
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
```
Given that the changes made in this PR are only in the nifi-runtime module,
**I think this PR can be merged**.
The full build, skipping tests and no contrib-check (`mvn clean install -T
C2 -DskipTests`) is successful.
However, the full build with contrib-check on, and tests skipped (`mvn
clean install -T C2 -Pcontrib-check`), or running Apache RAT exclusively (`mvn
apache-rat:check`) fails the RAT check in nifi-poi-processors.
```
Files with unapproved licenses:
C:/Users/Jeff/dev/git-repos/nifi/nifi-nar-bundles/nifi-poi-bundle/nifi-poi-processors/src/test/resources/Unsupported.xls
```
Also, some tests are failing when I'm running the full build. For
instance, in the nifi-file-authorizer module, some FileAuthorizer tests fail,
but they pass if I run those tests by invoking the tests in
nifi-file-authorizer specifically (from the nifi-file-authorizer module,
running `mvn test -Dtest=FileAuthorizerTest`).
There are also Toolkit CLI tests that are failing:
```
[ERROR]
testWhenAllDescriptionsAreEmpty(org.apache.nifi.toolkit.cli.impl.result.writer.TestDynamicTableWriter)
Time elapsed: 0 s <<< FAILURE!
org.junit.ComparisonFailure:
expected:<[
# Name Id Description
- -------- ----------------------------------- -----------
1 Bucket 1 12345-12345-12345-12345-12345-12345 (empty)
2 Bucket 2 12345-12345-12345-12345-12345-12345 (empty)
]
> but was:<[
# Name Id Description
- -------- ----------------------------------- -----------
1 Bucket 1 12345-12345-12345-12345-12345-12345 (empty)
2 Bucket 2 12345-12345-12345-12345-12345-12345 (empty)
]
>
```
The output looks the same to the eye, but the actual value tested against
the expected value fails because the EOL characters are different. In
TestDynamicTableWriter.java, the expected values in the tests use "\n" for EOL,
and if they are changed to "\r\n", the test passes on Windows. JIRAs will have
to be filed to go through the tests and updated them to use File.separator
instead of explicitly using "\n".
@nalewis [PR 2819](https://github.com/apache/nifi/pull/2819) was merged to
master on June 28, 2018, and is this PR is branched off of master from
yesterday. Those changes are already incorporated. What version of Windows
are you running?
---
