[
https://issues.apache.org/jira/browse/NIFI-5577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606364#comment-16606364
]
ASF GitHub Bot commented on NIFI-5577:
--------------------------------------
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2995
NIFI-5577 Fixing update method in NaiveRevisionManager so that failed…
… updates don't change the revision
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi NIFI-5577
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2995.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2995
----
commit 2a4342734556da006dc724af47518eb0941f92d7
Author: Bryan Bende <bbende@...>
Date: 2018-09-06T19:54:41Z
NIFI-5577 Fixing update method in NaiveRevisionManager so that failed
updates don't change the revision
----
> Component revision number can be incorrectly changed during a failed update
> ---------------------------------------------------------------------------
>
> Key: NIFI-5577
> URL: https://issues.apache.org/jira/browse/NIFI-5577
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.7.1
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Priority: Minor
>
> When an update of a component throws an exception, the revision number is
> incorrectly set to whatever the client passed in, and since clients are
> allowed to keep making requests without the latest revision number this means
> the revision number can incorrectly set back to some lower number.
> Steps to reproduce...
> * Create a GenerateFlowFile processor and get back revision 1
> * Change the name three times and get to revision 4
> * Submit an update where the revision is 1 and set the state to RUNNING
> which should fail because the component is invalid
> * Perform a GET for the processors and notice the revision is now 1 and not 4
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
