[ 
https://issues.apache.org/jira/browse/NIFI-5318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610799#comment-16610799
 ] 

ASF GitHub Bot commented on NIFI-5318:
--------------------------------------

Github user peter-gergely-horvath commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2872#discussion_r216713844
  
    --- Diff: 
nifi-testharness/src/main/java/org/apache/nifi/testharness/util/FileUtils.java 
---
    @@ -0,0 +1,88 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +
    +
    +package org.apache.nifi.testharness.util;
    +
    +import java.io.File;
    +import java.io.IOException;
    +import java.nio.file.FileVisitResult;
    +import java.nio.file.Files;
    +import java.nio.file.Path;
    +import java.nio.file.Paths;
    +import java.nio.file.SimpleFileVisitor;
    +import java.nio.file.attribute.BasicFileAttributes;
    +import java.util.Arrays;
    +
    +public final class FileUtils {
    +
    +
    +    private static final String MAC_DS_STORE_NAME = ".DS_Store";
    +
    +    private FileUtils() {
    +        // no instances
    +    }
    +
    +    public static void deleteDirectoryRecursive(Path directory) throws 
IOException {
    +        Files.walkFileTree(directory, new SimpleFileVisitor<Path>() {
    +            @Override
    +            public FileVisitResult visitFile(Path file, 
BasicFileAttributes attrs) throws IOException {
    +                Files.delete(file);
    +                return FileVisitResult.CONTINUE;
    +            }
    +
    +            @Override
    +            public FileVisitResult postVisitDirectory(Path dir, 
IOException exc) throws IOException {
    +                Files.delete(dir);
    +                return FileVisitResult.CONTINUE;
    +            }
    +        });
    +    }
    +
    +    public static void deleteDirectoryRecursive(File dir) {
    +        try {
    +            deleteDirectoryRecursive(dir.toPath());
    +        } catch (IOException e) {
    +            throw new RuntimeException(e);
    +        }
    +    }
    +
    +    public static void createLink(Path newLink, Path existingFile)  {
    +        try {
    +            Files.createSymbolicLink(newLink, existingFile);
    --- End diff --
    
    No, I have not tested this on Windows. I would expect it to work properly, 
since [Windows 10 does support symbolic 
links](https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10/). 
(you just need the [correct 
permission](https://docs.microsoft.com/en-us/windows/security/threat-protection/security-policy-settings/create-symbolic-links))



> Implement NiFi test harness
> ---------------------------
>
>                 Key: NIFI-5318
>                 URL: https://issues.apache.org/jira/browse/NIFI-5318
>             Project: Apache NiFi
>          Issue Type: New Feature
>            Reporter: Peter Horvath
>            Priority: Major
>
> Currently, it is not really possible to automatically test the behaviour of a 
> specific NiFi flow and make unit test type asserts if it works as expected. 
> For example, if the expected behaviour of a NiFi flow is that a file placed 
> to a specific directory will trigger some operation after which some output 
> file will appear at another directory, once currently can only do one thing: 
> test the NiFi flow manually. 
> Manual testing is especially hard to manage if a NiFi flow is being actively 
> developed: any change to a complex, existing NiFi flow might require a lot of 
> manual testing just to ensure there are no regressions introduced. 
> Some kind of Java API that allows managing a NiFi instance and manipulating 
> flow deployments like for example, [Codehaus 
> Cargo|]https://codehaus-cargo.github.io/] would be of great help. 
>  
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to