Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2945#discussion_r216874412
--- Diff:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
---
@@ -63,6 +63,19 @@ public RecordSchema getSchema() {
return schema;
}
+ // Protected methods for subclasses to access private member variables
+ protected ResultSet getResultSet() {
+ return rs;
+ }
+
+ protected boolean isMoreRows() {
--- End diff --
Is it better to call this `isMoreRows` or `hasMoreRows`? I have a feeling
the former might be a little more technically correct according to Java naming
standards, but the latter would be more intuitive and still convey boolean
there to the reader.
---
