[
https://issues.apache.org/jira/browse/NIFI-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613897#comment-16613897
]
ASF GitHub Bot commented on NIFI-4517:
--------------------------------------
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2945#discussion_r216874412
--- Diff:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/ResultSetRecordSet.java
---
@@ -63,6 +63,19 @@ public RecordSchema getSchema() {
return schema;
}
+ // Protected methods for subclasses to access private member variables
+ protected ResultSet getResultSet() {
+ return rs;
+ }
+
+ protected boolean isMoreRows() {
--- End diff --
Is it better to call this `isMoreRows` or `hasMoreRows`? I have a feeling
the former might be a little more technically correct according to Java naming
standards, but the latter would be more intuitive and still convey boolean
there to the reader.
> Allow SQL results to be output as records in any supported format
> -----------------------------------------------------------------
>
> Key: NIFI-4517
> URL: https://issues.apache.org/jira/browse/NIFI-4517
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> ExecuteSQL and QueryDatabaseTable currently only outputs Avro, and the schema
> is only available as embedded within the flow file, not as an attribute such
> as record-aware processors can handle.
> ExecuteSQLÂ and QueryDatabaseTable processors should be updated with a
> RecordSetWriter implementation. This will allow output using any writer
> format (Avro, JSON, CSV, Free-form text, etc.), as well as all the other
> features therein (such as writing the schema to an attribute, and will avoid
> the need for a ConvertAvroToXYZ or ConvertRecord processor downstream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
