Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2990
@ijokarumawak This is looking really good! Just seeing a couple minor
things aside from the NPE I commented in the code.
It looks like the `operatePermissions` were added to the `ComponentEntity`.
This is good since this applied to the majority of components. However, I
noticed that the `operatePermissions` was also added to the each of the
concrete implementations (`ProcessorEntity`, `PortEntity`, etc). I do not
believe we need the field and getter/setter methods within each concrete
implementation. Is there a reason they are there?
Also, I think we need to apply the new `Operation` policy checks in
`FlowResource#activeControllerServices`. This is essentially like the
corresponding `FlowResource#scheduleComponents` but for `ControllerServices`.
This endpoint is not called directly by the NiFi UI but I think it should
probably utilize the new policy.
Thanks again!
---
