[
https://issues.apache.org/jira/browse/NIFI-5614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16621323#comment-16621323
]
ASF GitHub Bot commented on NIFI-5614:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/3014
NIFI-5614: Update commons-dbcp to commons-dbcp2 for DBCPConnectionPool
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [x] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5614
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3014.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3014
----
commit 752af4509dea48296ad5f561ee99eeb9c7674a9e
Author: Matthew Burgess <mattyb149@...>
Date: 2018-09-19T23:34:17Z
NIFI-5614: Update commons-dbcp to commons-dbcp2 for DBCPConnectionPool
----
> Upgrade commons-dbcp to latest commons-dbcp2
> --------------------------------------------
>
> Key: NIFI-5614
> URL: https://issues.apache.org/jira/browse/NIFI-5614
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> DBCPConnectionPool currently uses Commons DBCP 1.4. There have been [many
> improvements and a major
> release|https://commons.apache.org/proper/commons-dbcp/changes-report.html#a2.5.0]
> since then, at the time of this writing the latest version is 2.5.0.
> This Jira proposes to upgrade the version of commons-dbcp to commons-dbcp2
> version 2.5.0 in order to benefit from the improvements/additions. This will
> involve some code changes in addition to the updated dependencies, as the API
> has changed slightly to use different terminology e.g.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
