Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3010#discussion_r219293091
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/replication/ThreadPoolRequestReplicator.java
---
@@ -180,6 +181,15 @@ public AsyncClusterResponse replicate(NiFiUser user,
String method, URI uri, Obj
}
}
+ final List<NodeIdentifier> decommissioning =
stateMap.get(NodeConnectionState.DECOMMISSIONING);
--- End diff --
I think we need to also check for any nodes that are decommissioned as
well. At first i thought maybe we should just allow it if a node is
decommissioned. But then it's a little weird because the UI still will show 3/4
nodes connected (for example). And in all other cases, we would reject the
request because the cluster is not at 100% connected. So I think we need to
disallow even for decommissioned nodes.
---
