Github user jtstorck commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3010#discussion_r219607209
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/replication/ThreadPoolRequestReplicator.java
---
@@ -180,6 +181,15 @@ public AsyncClusterResponse replicate(NiFiUser user,
String method, URI uri, Obj
}
}
+ final List<NodeIdentifier> decommissioning =
stateMap.get(NodeConnectionState.DECOMMISSIONING);
--- End diff --
I agree. If requests were replicated to nodes other than decommissioned
nodes, then the decommissioned node would be out of sync with the rest of the
cluster and would not be able to rejoin the cluster. I added a check for the
decommissioned state.
---
