[ 
https://issues.apache.org/jira/browse/MINIFICPP-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16628625#comment-16628625
 ] 

ASF GitHub Bot commented on MINIFICPP-618:
------------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/405#discussion_r220525598
  
    --- Diff: libminifi/include/c2/C2Trigger.h ---
    @@ -0,0 +1,63 @@
    +/**
    + *
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +#ifndef LIBMINIFI_INCLUDE_C2_C2TRIGGER_H_
    +#define LIBMINIFI_INCLUDE_C2_C2TRIGGER_H_
    +
    +#include "core/Connectable.h"
    +#include "c2/C2Payload.h"
    +#include "properties/Configure.h"
    +
    +namespace org {
    +namespace apache {
    +namespace nifi {
    +namespace minifi {
    +namespace c2 {
    +
    +class C2Trigger : public core::Connectable{
    + public:
    +
    +  C2Trigger(std::string name, utils::Identifier uuid)
    +        : core::Connectable(name, uuid){
    +
    +  }
    +  virtual ~C2Trigger() {
    +  }
    +
    +
    +  /**
    --- End diff --
    
    You were right. I went through and added some comments and probably would 
have missed this had you not mentioned it. Thanks! adding some docs now to our 
readmes.
    Made an early PR to give some people a chance to review and test -- so 
really appreciate all input!


> Add C2 triggers for local updates
> ---------------------------------
>
>                 Key: MINIFICPP-618
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-618
>             Project: NiFi MiNiFi C++
>          Issue Type: New Feature
>            Reporter: Mr TheSegfault
>            Assignee: Mr TheSegfault
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to