[
https://issues.apache.org/jira/browse/NIFI-5640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16630497#comment-16630497
]
ASF GitHub Bot commented on NIFI-5640:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/3036
NIFI-5640: Improved efficiency of Avro Reader and some methods of Avr…
…oTypeUtil. Also switched ServiceStateTransition to using read/write locks
instead of synchronized blocks because profiling showed that significant time
was spent in determining state of a Controller Service when attempting to use
it. Switching to a ReadLock should provide better performance there.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5640
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3036.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3036
----
commit 6e1d1cc2cccc33282998953b5c8d612df7c80030
Author: Mark Payne <markap14@...>
Date: 2018-09-27T14:10:48Z
NIFI-5640: Improved efficiency of Avro Reader and some methods of
AvroTypeUtil. Also switched ServiceStateTransition to using read/write locks
instead of synchronized blocks because profiling showed that significant time
was spent in determining state of a Controller Service when attempting to use
it. Switching to a ReadLock should provide better performance there.
----
> Improve efficiency of Avro Record Reader
> ----------------------------------------
>
> Key: NIFI-5640
> URL: https://issues.apache.org/jira/browse/NIFI-5640
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Major
>
> There are a few things that we are doing in the Avro Reader that cause subpar
> performance. Firstly, in the AvroTypeUtil, when converting an Avro
> GenericRecord to our Record, the building of the RecordSchema is slow because
> we call toString() (which is quite expensive) on the Avro schema in order to
> provide a textual version to RecordSchema. However, the text is typically not
> used and it is optional to provide the schema text, so we should avoid
> calling Schema#toString() whenever possible.
> The AvroTypeUtil class also calls #getNonNullSubSchemas() a lot. In some
> cases we don't really need to do this and can avoid creating the sublist. In
> other cases, we do need to call it. However, the method uses the stream()
> method on an existing List just to filter out 0 or 1 elements. While use of
> the stream() method makes the code very readable, it is quite a bit more
> expensive than just iterating over the existing list and adding to an
> ArrayList. We should avoid use of the {{stream()}} method for trivial pieces
> of code in time-critical parts of the codebase.
> Additionally, I've found that Avro's GenericDatumReader is extremely
> inefficient, at least in some cases, when reading Strings because it uses an
> IdentityHashMap to cache details about the schema. But IdentityHashMap is far
> slower than if it were to just use HashMap so we could subclass the reader in
> order to avoid the slow caching.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
