[
https://issues.apache.org/jira/browse/NIFI-5650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16634091#comment-16634091
]
ASF GitHub Bot commented on NIFI-5650:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/3042
NIFI-5650: Added Xerces to scripting bundle for Jython 2.7.1
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [x] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5650
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3042.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3042
----
commit 857b76f4af082c364e18bc21a8b24d42c9a278ab
Author: Matthew Burgess <mattyb149@...>
Date: 2018-10-01T14:23:44Z
NIFI-5650: Added Xerces to scripting bundle for Jython 2.7.1
----
> Add xercesImpl to scripting NAR for Jython 2.7.1
> ------------------------------------------------
>
> Key: NIFI-5650
> URL: https://issues.apache.org/jira/browse/NIFI-5650
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> NIFI-4301 bumped the version of Jython from Jython 2.7.0 to 2.7.1 in order to
> get a fix related to the os.getpid() method. However Jython 2.7.1 does not
> include Xerces (which provides the SAXParser for XML parsing), so although
> one bug is fixed, a capability has been degraded.
> Recommend explicitly adding Xerces as a dependency to the scripting NAR, and
> make sure the unit tests and such run for other languages, so as not to
> introduce a classloading issue if some engine brings their own Xerces shaded
> into the engine's JAR(s), for example.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
