Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/408#discussion_r222282701
--- Diff: thirdparty/spdlog-20170710/include/spdlog/details/os.h ---
@@ -459,9 +459,9 @@ inline bool in_terminal(FILE* file)
{
#ifdef _WIN32
- return _isatty(_fileno(file)) ? true : false;
--- End diff --
While we do have some specializations changing a third party library for
readability and not functionality might not be the most ideal if we have to
compare across versions.
---
