[jira] [Commented] (NIFI-5516) Allow data in a Connection to be Load-Balanced across cluster

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/NIFI-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16637643#comment-16637643
 ] 

ASF GitHub Bot commented on NIFI-5516:
--------------------------------------

Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2947#discussion_r222506249
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FileSystemSwapManager.java
 ---
    @@ -70,9 +71,8 @@
      */
     public class FileSystemSwapManager implements FlowFileSwapManager {
     
    -    public static final int MINIMUM_SWAP_COUNT = 10000;
    -    private static final Pattern SWAP_FILE_PATTERN = 
Pattern.compile("\\d+-.+\\.swap");
    -    private static final Pattern TEMP_SWAP_FILE_PATTERN = 
Pattern.compile("\\d+-.+\\.swap\\.part");
    +    private static final Pattern SWAP_FILE_PATTERN = 
Pattern.compile("\\d+-.+(\\..*?)?\\.swap");
    +    private static final Pattern TEMP_SWAP_FILE_PATTERN = 
Pattern.compile("\\d+-.+(\\..*?)?\\.swap\\.part");
    --- End diff --
    
    The extra ? after '+' is needed if the bracket is meant to capture the 
optional partition_name part. Anyway, it's not critical since the regex can 
match with expected strings..
    
    Using regex101.com, we can see the difference:
    https://regex101.com/
    
    
![image](https://user-images.githubusercontent.com/1107620/46446278-56db7b80-c7b6-11e8-877d-fa653395e68b.png)
    
    
![image](https://user-images.githubusercontent.com/1107620/46446268-4cb97d00-c7b6-11e8-86e2-816b68e01fde.png)



> Allow data in a Connection to be Load-Balanced across cluster
> -------------------------------------------------------------
>
>                 Key: NIFI-5516
>                 URL: https://issues.apache.org/jira/browse/NIFI-5516
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Major
>
> Allow user to configure a Connection to be load balanced across the cluster. 
> For more information, see Feature Proposal at 
> https://cwiki.apache.org/confluence/display/NIFI/Load-Balanced+Connections



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)