[ 
https://issues.apache.org/jira/browse/NIFI-5660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643616#comment-16643616
 ] 

ASF GitHub Bot commented on NIFI-5660:
--------------------------------------

Github user joewitt commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3053#discussion_r223748531
  
    --- Diff: 
nifi-nar-bundles/nifi-jms-bundle/nifi-jms-processors/src/main/java/org/apache/nifi/jms/processors/JMSPublisher.java
 ---
    @@ -89,11 +89,14 @@ void setMessageHeaderAndProperties(final Message 
message, final Map<String, Stri
                 for (Entry<String, String> entry : 
flowFileAttributesToSend.entrySet()) {
                     try {
                         if (entry.getKey().equals(JmsHeaders.DELIVERY_MODE)) {
    -                        
message.setJMSDeliveryMode(Integer.parseInt(entry.getValue()));
    +                        this.jmsTemplate.setExplicitQosEnabled(true);
    --- End diff --
    
    are setting these values explicitly and without any configurability going 
to limit usage of these processors for certain JMS brokers? 


> JMSPublisher should not set header properties directly in the message
> ---------------------------------------------------------------------
>
>                 Key: NIFI-5660
>                 URL: https://issues.apache.org/jira/browse/NIFI-5660
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>    Affects Versions: 1.7.1
>            Reporter: Mark Bean
>            Priority: Major
>
> JMS clients cannot set most header properties directly in the message, and 
> they have to call other methods to change the default values. Most header 
> properties are set indirectly when the provider code publishes a message. The 
> defaults for QOS properties (delivery mode, expiration and priority) have to 
> be changed by explicit calls to the Spring JMSTemplate class. The only header 
> values that can be set directly by the client code are JMSReplyTo, 
> JMSCorrelationID and JMSType. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to