GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/3057

    NIFI-5667: Add nested record support for PutORC

    The basic approach here is that I removed all references to Avro 
schemas/fields and replaced them with NiFi Record API concepts. This allows us 
to not have to switch back and forth, since Avro is not the de facto standard 
for schemas or flow file content (although we are still fairly tightly coupled 
to Avro schemas, but that's a different issue :) )
    
    I'll comment in the PR on various parts of the code to note the "real" 
changes to fix the reported issue.
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-5667

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/3057.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3057
    
----
commit ab16d6f77c7dead859643492fe650685ffd7e4ba
Author: Matthew Burgess <mattyb149@...>
Date:   2018-10-09T22:59:00Z

    NIFI-5667: Add nested record support for PutORC

----


---

Reply via email to