[
https://issues.apache.org/jira/browse/NIFI-5676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644381#comment-16644381
]
ASF GitHub Bot commented on NIFI-5676:
--------------------------------------
GitHub user kotarot opened a pull request:
https://github.com/apache/nifi/pull/3059
NIFI-5676: Fix a timezone-dependent test in PutORCTest
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kotarot/nifi NIFI-5676
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3059.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3059
----
commit 323e210b3fb758fb1031711c1dbb17b104a27fe6
Author: Kotaro Terada <koterada@...>
Date: 2018-10-09T05:12:53Z
Fix a timezone-dependent test in PutORCTest
----
> A test in PutORCTest fails because it depends on timezone
> ---------------------------------------------------------
>
> Key: NIFI-5676
> URL: https://issues.apache.org/jira/browse/NIFI-5676
> Project: Apache NiFi
> Issue Type: Test
> Reporter: Kotaro Terada
> Priority: Major
>
> Test {{testWriteORCWithAvroLogicalTypes}} fails because it depends on
> timezone. It seems that, in this test, the converted date in ORC is "1 day"
> before the input date when the timezone is ahead of GMT. For example, when
> the timezone is "GMT+9", this test fails as follows:
> {noformat}
> [INFO] Running org.apache.nifi.processors.orc.PutORCTest
> [ERROR] Tests run: 7, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.694
> s <<< FAILURE! - in org.apache.nifi.processors.orc.PutORCTest
> [ERROR]
> testWriteORCWithAvroLogicalTypes(org.apache.nifi.processors.orc.PutORCTest)
> Time elapsed: 0.146 s <<< FAILURE!
> java.lang.AssertionError: expected:<17813> but was:<17812>
> at
> org.apache.nifi.processors.orc.PutORCTest.lambda$testWriteORCWithAvroLogicalTypes$1(PutORCTest.java:250)
> at
> org.apache.nifi.processors.orc.PutORCTest.verifyORCUsers(PutORCTest.java:408)
> at
> org.apache.nifi.processors.orc.PutORCTest.testWriteORCWithAvroLogicalTypes(PutORCTest.java:246)
> {noformat}
> To fix this, we can set the timezone information in the assertion as we did
> in [NIFI-3718|https://issues.apache.org/jira/browse/NIFI-3718].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
