[
https://issues.apache.org/jira/browse/NIFI-5681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646096#comment-16646096
]
ASF GitHub Bot commented on NIFI-5681:
--------------------------------------
GitHub user kotarot opened a pull request:
https://github.com/apache/nifi/pull/3061
NIFI-5681: Fix a locale-dependent test in
TestVersionedFlowSnapshotMetadataResult
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kotarot/nifi NIFI-5681
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3061.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3061
----
commit 66753f6b05cb53a32d20a379441d98b6722e79da
Author: Kotaro Terada <koterada@...>
Date: 2018-10-09T09:31:41Z
Fix a locale-dependent test in TestVersionedFlowSnapshotMetadataResult
----
> A test in TestVersionedFlowSnapshotMetadataResult fails because it depends on
> locale
> ------------------------------------------------------------------------------------
>
> Key: NIFI-5681
> URL: https://issues.apache.org/jira/browse/NIFI-5681
> Project: Apache NiFi
> Issue Type: Test
> Reporter: Kotaro Terada
> Priority: Major
>
> Test {{testWriteSimpleVersionedFlowSnapshotResult}} in
> {{TestVersionedFlowSnapshotMetadataResult}} class fails with an assertion
> error when the locale is not "en_US" (or similar locale). When the locale is
> "ja_JP", the test fails as follows:
> {noformat}
> [INFO] Running
> org.apache.nifi.toolkit.cli.impl.result.TestVersionedFlowSnapshotMetadataResult
> [ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.028
> s <<< FAILURE! - in
> org.apache.nifi.toolkit.cli.impl.result.TestVersionedFlowSnapshotMetadataResult
> [ERROR]
> testWriteSimpleVersionedFlowSnapshotResult(org.apache.nifi.toolkit.cli.impl.result.TestVersionedFlowSnapshotMetadataResult)
> Time elapsed: 0.027 s <<< FAILURE!
> java.lang.AssertionError
> at
> org.apache.nifi.toolkit.cli.impl.result.TestVersionedFlowSnapshotMetadataResult.testWriteSimpleVersionedFlowSnapshotResult(TestVersionedFlowSnapshotMetadataResult.java:79)
> {noformat}
> The content of {{resultOut}} is now:
> {noformat}
> Ver Date Author Message
>
> --- ---------------------- ------
> ----------------------------------------
> 1 水, 2 14 2018 12:00 JST user1 This is a long comment, longer than
> t...
> 2 水, 2 14 2018 12:30 JST user2 This is v2
>
> {noformat}
> Even if checking the heading two lines (as we do now), length of a line is
> different by each locale because width of columns depends on locale. We can
> deal with this problem using regex.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
