[
https://issues.apache.org/jira/browse/NIFI-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646980#comment-16646980
]
ASF GitHub Bot commented on NIFI-5680:
--------------------------------------
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/3065
NIFI-5680 Handling trailing slashes on URLs of registry clients
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi NIFI-5680
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3065.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3065
----
commit 93e06fdcfa02d10a60e69fbc4b9162e869eef0fa
Author: Bryan Bende <bbende@...>
Date: 2018-10-11T19:58:55Z
NIFI-5680 Handling trailing slashes on URLs of registry clients
----
> Using inconsistent location URL for Registry Client on different NiFi
> instances will break ability to import version controlled flows that contain
> nested version controlled flows.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: NIFI-5680
> URL: https://issues.apache.org/jira/browse/NIFI-5680
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Affects Versions: 1.5.0, 1.6.0, 1.7.0
> Reporter: Matthew Clarke
> Assignee: Bryan Bende
> Priority: Major
>
> Using inconsistent location URL for Registry Client on different NiFi
> instances will break ability to import version controlled flows that contain
> nested version controlled flows.
> For example:
> on NiFi instance 1, configure "Registry Client" location URL with
> https://<nifi-registry>:<port>/
> on NiFi instance 2, configure "Registry Client" location URL with
> https://<nifi-registry>:<port>
> notice that one contains a trailing "/"
> On one of your NiFi instances, create a Process Group (PG).
> Inside that PG, create another "sub-PG".
> Start version control of sub-PG.
> Go back to parent PG and also start version control on that "PG".
> Go to your other NiFi instance and try to "import" the "PG" version
> controlled flow.
> Import will fail and throw following error in nifi-user.log:
> o.a.n.w.a.c.IllegalArgumentExceptionMapper
> java.lang.IllegalArgumentException: The Flow Registry with ID <UUID> reports
> that no Flow exists with Bucket <UUID>, Flow <UUID, Version 2. Returning Bad
> Request response.
> Even though registry does include the referenced UUIDs in that log output.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
