[
https://issues.apache.org/jira/browse/NIFI-5601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650713#comment-16650713
]
ASF GitHub Bot commented on NIFI-5601:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/3074
NIFI-5601: Add fragment.* attributes to GenerateTableFetch
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5601
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3074.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3074
----
commit bd6ce6d8c74b65a222fb2a842465e5aae2d40272
Author: Matthew Burgess <mattyb149@...>
Date: 2018-10-15T20:07:13Z
NIFI-5601: Add fragment.* attributes to GenerateTableFetch
----
> Add fragment.* attributes to GenerateTableFetch
> -----------------------------------------------
>
> Key: NIFI-5601
> URL: https://issues.apache.org/jira/browse/NIFI-5601
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> GenerateTableFetch will generate SQL statements in multiple flow files
> corresponding to "pages" of data for a single execution of the processor.
> QueryDatabaseTable does something similar, although it also does the fetching
> of the rows and adds fragment.* attributes to the outgoing flow files, in
> case a merge or other correlation needs to be done later.
> GenerateTableFetch (although it doesn't produce source data per se) is
> usually used in conjunction with ExecuteSQL to fetch the actual pages of
> rows, and sometimes these would need to be merged/correlated. To that end,
> this Jira proposes to add the same fragment.* attributes to the outgoing GTF
> flow files for use downstream.
> Note that if the SQL statements are distributed among a cluster (for parallel
> execution by ExecuteSQL), they will not be able to be merged, as different
> nodes may get different fragments and often no single node will get all the
> fragments.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
