[
https://issues.apache.org/jira/browse/NIFI-5604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16650745#comment-16650745
]
ASF GitHub Bot commented on NIFI-5604:
--------------------------------------
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/3075
NIFI-5604: Added property to allow empty FlowFile when no SQL generated by
GenerateTableFetch
Note that this should work with NIFI-5601 (#3074) such that the fragment
attributes would be written to the empty flow file as well. Depending on which
gets merged first, the other probably needs to be updated.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-5604
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3075.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3075
----
commit 43bfe9531a0aa2a64179d27b4196a6062f60ebbe
Author: Matthew Burgess <mattyb149@...>
Date: 2018-10-15T20:27:38Z
NIFI-5604: Added property to allow empty FlowFile when no SQL generated by
GenerateTableFetch
----
> Allow GenerateTableFetch to send empty flow files when no rows would be
> fetched
> -------------------------------------------------------------------------------
>
> Key: NIFI-5604
> URL: https://issues.apache.org/jira/browse/NIFI-5604
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Reporter: Matt Burgess
> Assignee: Matt Burgess
> Priority: Major
>
> Currently, GenerateTableFetch will not output a flow file if there are no
> rows to be fetched. However, it may be desired (especially with incoming flow
> files) that a flow file be sent out even if GTF does not generate any SQL.
> This capability, along with the fragment attributes from NIFI-5601, would
> allow the user to handle this downstream.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
