[
https://issues.apache.org/jira/browse/NIFI-5689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652339#comment-16652339
]
ASF GitHub Bot commented on NIFI-5689:
--------------------------------------
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/3084
NIFI-5689 ReplaceText does not handle end of line correctly on buffer…
… boundary
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [x] Have you written or updated unit tests to verify your changes?
- [-] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [-] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [-] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [-] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [-] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ottobackwards/nifi replacetext-line-endings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3084.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3084
----
commit 451c11e2eff0a9416563119ce8df639c30f12674
Author: Otto Fowler <ottobackwards@...>
Date: 2018-10-16T19:45:05Z
NIFI-5689 ReplaceText does not handle end of line correctly on buffer
boundary
----
> ReplaceText does not handle end of line correctly on buffer boundary
> --------------------------------------------------------------------
>
> Key: NIFI-5689
> URL: https://issues.apache.org/jira/browse/NIFI-5689
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.7.1
> Reporter: Sergei Zhirikov
> Assignee: Otto Fowler
> Priority: Minor
> Attachments: Text_Parsing_Bug.xml
>
>
> ReplaceText appears to misbehave under the following conditions:
> * The input flow file contains text with Windows-style line endings (CR-LF).
> * ReplaceText is configured to perform "Regex Replace" in "Line-by-Line"
> mode.
> * The "Maximum Buffer Size" is set to a value smaller than the whole file
> content,
> but large enough to fit any of the text lines in the file.
> * A CR-LF pair of characters in one of the lines happens to be split across
> two buffers,
> that is CR is the last character in one buffer and LF is the first one in the
> following one.
> An example flow template is attached to illustrate the problem.
> In the example, the regular expression is intended to remove white space at
> the end of each line. It operates as expected in all lines except the third
> one (containing "GHI"). That line satisfies the conditions described above.
> As a result the CR character in the end of the line is removed, which does
> not happen in other lines.
> In some more complicated cases both CR and LF end up being removed,
> effectively resulting in two lines being joined into one. Although, I haven't
> managed to create a simple test case to reproduce that.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
