[
https://issues.apache.org/jira/browse/MINIFICPP-642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652377#comment-16652377
]
ASF GitHub Bot commented on MINIFICPP-642:
------------------------------------------
GitHub user apiri opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/418
MINIFICPP-642 Disable shared libs for Docker image build.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apiri/nifi-minifi-cpp MINIFICPP-642
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/418.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #418
----
commit 21d9b547c21b9836411f9bb6454b297c86323b47
Author: Aldrin Piri <aldrinpiri@...>
Date: 2018-10-16T19:51:46Z
MINIFICPP-642 Disable shared libs for Docker image build.
----
> Shared lib building causes issues in Docker image
> -------------------------------------------------
>
> Key: MINIFICPP-642
> URL: https://issues.apache.org/jira/browse/MINIFICPP-642
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Reporter: Aldrin Piri
> Assignee: Aldrin Piri
> Priority: Major
> Fix For: 0.6.0
>
>
> With the adjustment to the CMakeLists in support of Python there have proven
> to be issues with the shared libs in the docker environment.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
