[
https://issues.apache.org/jira/browse/NIFI-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652613#comment-16652613
]
ASF GitHub Bot commented on NIFI-5714:
--------------------------------------
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/3086
NIFI-5714 - Hive[3]ConnectionPool - Kerberos Authentication issue/mis…
…leading
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-5714
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3086.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3086
----
commit 0fc99a19057bbbc7e1c8123e8cbc8e408c53873c
Author: Pierre Villard <pierre.villard.fr@...>
Date: 2018-10-16T23:04:16Z
NIFI-5714 - Hive[3]ConnectionPool - Kerberos Authentication issue/misleading
----
> Hive[3]ConnectionPool - Kerberos Authentication issue/misleading
> ----------------------------------------------------------------
>
> Key: NIFI-5714
> URL: https://issues.apache.org/jira/browse/NIFI-5714
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.1.0, 1.2.0, 1.1.1, 1.0.1, 1.3.0, 1.4.0, 1.5.0, 1.6.0,
> 1.7.0, 1.7.1
> Reporter: Pierre Villard
> Assignee: Pierre Villard
> Priority: Major
>
> In {{HiveConnectionPool}} and {{Hive3ConnectionPool}}, in the {{@OnEnabled}}
> method, we have:
> {code:java}
> log.info("Hive Security Enabled, logging in as principal {} with keytab {}",
> new Object[] {resolvedPrincipal, resolvedKeytab});
> try {
> ugi = hiveConfigurator.authenticate(hiveConfig, resolvedPrincipal,
> resolvedKeytab);
> } catch (AuthenticationFailedException ae) {
> log.error(ae.getMessage(), ae);
> }
> getLogger().info("Successfully logged in as principal {} with keytab {}", new
> Object[] {resolvedPrincipal, resolvedKeytab});{code}
> Which causes two issues:
> * we're logging the successful message even though the authentication failed
> * the Hive connection is created using the NiFi user identity (this would
> need to be confirmed but that's what I observed during a test - it could be
> due to the environment though)
> In my opinion, an {{InitializationException}} should be thrown so that the
> controller service is not enabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
