[GitHub] nifi-minifi-cpp pull request #418: MINIFICPP-642 Disable shared libs for Doc...

[phrocker]

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/418#discussion_r225742123
  
    --- Diff: docker/Dockerfile ---
    @@ -67,7 +67,7 @@ ENV MINIFI_HOME 
$MINIFI_BASE_DIR/nifi-minifi-cpp-$MINIFI_VERSION
     RUN cd $MINIFI_BASE_DIR \
        && mkdir build \
        && cd build \
    -   && cmake .. \
    +   && cmake -DBUILD_SHARED_LIBS=OFF .. \
    --- End diff --
    
    what issues does this present?


---