Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225496736
  
    --- Diff: libminifi/src/capi/api.cpp ---
    @@ -212,7 +214,7 @@ void free_flowfile(flow_file_record *ff) {
      * @param size size of value
      * @return 0 or -1 based on whether the attributed existed previously (-1) 
or not (0)
      */
    -uint8_t add_attribute(flow_file_record *ff, char *key, void *value, size_t 
size) {
    +uint8_t add_attribute(flow_file_record *ff, const char *key, void *value, 
size_t size) {
    --- End diff --
    
    Additionally, I'm not sure why value is not a char, but can't change that 
if we release it as 0.6.0


---

Reply via email to