[ 
https://issues.apache.org/jira/browse/MINIFICPP-638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652703#comment-16652703
 ] 

ASF GitHub Bot commented on MINIFICPP-638:
------------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/417#discussion_r225500772
  
    --- Diff: libminifi/src/capi/api.cpp ---
    @@ -361,6 +396,18 @@ processor *add_processor(flow *flow, const char 
*processor_name) {
       }
       return nullptr;
     }
    +
    +processor *add_processor_with_linkage(flow *flow, const char 
*processor_name) {
    +  ExecutionPlan *plan = static_cast<ExecutionPlan*>(flow->plan);
    +  auto proc = plan->addProcessor(processor_name, processor_name, 
core::Relationship("success", "description"), true);
    --- End diff --
    
    That may mean removing the _with_linkage but that might make the API tidier 


> C API: add unit tests
> ---------------------
>
>                 Key: MINIFICPP-638
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-638
>             Project: NiFi MiNiFi C++
>          Issue Type: Sub-task
>            Reporter: Arpad Boda
>            Assignee: Arpad Boda
>            Priority: Minor
>             Fix For: 0.6.0
>
>
> Add some C API unit tests. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to