[
https://issues.apache.org/jira/browse/NIFI-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653738#comment-16653738
]
ASF GitHub Bot commented on NIFI-5719:
--------------------------------------
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/3088
NIFI-5719 Ensuring FetchFile routes to failure if the move completion…
… strategy can't be completed
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi fetch-file
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3088.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3088
----
commit a05e70e847a6a04dfb0d7d1822d0770185f4be45
Author: Bryan Bende <bbende@...>
Date: 2018-10-17T15:28:29Z
NIFI-5719 Ensuring FetchFile routes to failure if the move completion
strategy can't be completed
----
> FetchFile can fail to move original file on completion but still route to
> success
> ---------------------------------------------------------------------------------
>
> Key: NIFI-5719
> URL: https://issues.apache.org/jira/browse/NIFI-5719
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.7.1
> Reporter: Bryan Bende
> Assignee: Bryan Bende
> Priority: Minor
>
> Currently before fetching the file there are some checks to ensure that the
> completion strategy will succeed. The check for the move strategy ensures
> that if the target directory exists that it is a directory and is writable.
> The issue is that if the directory does not exist, then later during the
> actual move we try to create it, but this could fail, primarily due to the
> parent directory not being writable.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
