[ 
https://issues.apache.org/jira/browse/NIFI-4805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654086#comment-16654086
 ] 

ASF GitHub Bot commented on NIFI-4805:
--------------------------------------

Github user joewitt commented on the issue:

    https://github.com/apache/nifi/pull/3078
  
    We should avoid calling this processor a 'PenalizeFlowFile' processor.  
First, we have a notion of penalization in the framework already and it has a 
very specific meaning and it kicks in when processors reach certain failure 
conditions that are believed to be specific to a given flowfile or set of 
flowfiles and that by penalizing them the condition might improve on its own.  
Second, the use for this processor in a flow might not be for the purposes of 
penalizing that flowfile but rather might simply be to cause a given wait or 
hold to occur.  I'd recommend calling it DelayFlowFile.
    
    <...then I went and looked at the code>
    It is literally just calling penalize flow file so it makes sense why the 
name was given.
    
    What use case is this for again?
    
    If we're really wanting to create a DelayFlowFile processor, which is what 
it sounds  like was the intent, we should do that because penalization means 
something else.


> allow delayed transfer
> ----------------------
>
>                 Key: NIFI-4805
>                 URL: https://issues.apache.org/jira/browse/NIFI-4805
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Martin Mucha
>            Assignee: Peter Wicks
>            Priority: Minor
>         Attachments: retry.xml
>
>
> Nifi has concept of penalization, but this penalization has fixed delay, and 
> there isn't way how to change it dynamically. 
> If we want to implement retry flow, where FlowFile flows in loop, we can 
> either lower performance of Processor via yielding it, or we can do active 
> waiting. And this is actually recommended as a correct way how to do that.
> It seems, that we can easily implement better RetryProcessor, all we missing 
> is `session.penalize` which accepts `penalizationPeriod`. Processor then can 
> gradually prolong waiting time after each failure.
>  
> Would it be possible to make such method visible?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to