Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/420#discussion_r226382717
--- Diff: libminifi/src/capi/api.cpp ---
@@ -57,38 +57,28 @@ class DirectoryConfiguration {
}
};
-nifi_port *create_port(const char *port) {
- if (nullptr == port)
- return nullptr;
- nifi_port *p = new nifi_port();
- p->port_id = new char[strlen(port) + 1];
- memset(p->port_id, 0x00, strlen(port) + 1);
- strncpy(p->port_id, port, strlen(port));
- return p;
-}
-
-int free_port(nifi_port *port) {
- if (port == nullptr)
- return -1;
- delete[] port->port_id;
- delete port;
- return 0;
-}
-
/**
* Creates a NiFi Instance from the url and output port.
* @param url http URL for NiFi instance
* @param port Remote output port.
+ * @Deprecated for 0.6.0 in favor of
--- End diff --
Sorry to nitpick, but shall we refer to minifi releases or API version,
could see this getting a little confusing at some point? How could we best
document these version relationships?
---
