[
https://issues.apache.org/jira/browse/NIFI-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657379#comment-16657379
]
ASF GitHub Bot commented on NIFI-4558:
--------------------------------------
GitHub user thenatog opened a pull request:
https://github.com/apache/nifi/pull/3097
Revert "NIFI-4558 - Set JKS as the default keystore type and truststo…
…re type."
This reverts commit 2b9fdf8415eb2b033bfc63a6c5254bba3e69ecdd.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thenatog/nifi NIFI-4558-rebased
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3097.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3097
----
commit ddc4e28967c55ebe3522c16dc1e0bd642936e534
Author: thenatog <thenatog@...>
Date: 2018-10-19T19:46:12Z
Revert "NIFI-4558 - Set JKS as the default keystore type and truststore
type."
This reverts commit 2b9fdf8415eb2b033bfc63a6c5254bba3e69ecdd.
----
> Populate default keystore/truststore types in SSLContextService
> ---------------------------------------------------------------
>
> Key: NIFI-4558
> URL: https://issues.apache.org/jira/browse/NIFI-4558
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Extensions
> Affects Versions: 1.4.0
> Reporter: Andy LoPresto
> Assignee: Nathan Gough
> Priority: Trivial
> Labels: controller_services, jks, keystore, pkcs12, security,
> ssl, tls, truststore, ux
> Fix For: 1.8.0
>
>
> The keystore and truststore type is almost always JKS as opposed to PKCS12
> when creating SSL controller services. Both {{StandardSSLContextService}} and
> {{StandardRestrictedSSLContextService}} should have those fields
> autopopulated to JKS, saving 2-4 clicks per instantiation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
