GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/3106
NIFI-5741: When returning a ConnectionFactory from the JndiJmsConnectâ¦
â¦ionFactoryProvider, ensure that we wrap the ConnectionFactory so that
any calls to the ConnectionFactory happen within the context of the Controller
Service's Class Loader
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5741
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3106.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3106
----
commit a618a6d1ab3c1aa053c5e67a6aa89485a792bd60
Author: Mark Payne <markap14@...>
Date: 2018-10-23T18:42:32Z
NIFI-5741: When returning a ConnectionFactory from the
JndiJmsConnectionFactoryProvider, ensure that we wrap the ConnectionFactory so
that any calls to the ConnectionFactory happen within the context of the
Controller Service's Class Loader
----
---
