[
https://issues.apache.org/jira/browse/NIFI-5224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16665278#comment-16665278
]
ASF GitHub Bot commented on NIFI-5224:
--------------------------------------
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3041#discussion_r228563247
--- Diff: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/pom.xml ---
@@ -147,6 +147,12 @@
<version>2.2.1</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-solr-client-api</artifactId>
+ <version>1.8.0-SNAPSHOT</version>
+ <scope>compile</scope>
--- End diff --
Was able to try it out and you are right that it is working, but currently
this is only because the service impl happens to be in the same NAR as the
processors. If someone implemented their own SolrClientService in another NAR
then it wouldn't be able to be used in the current state.
If you just change the above dependency to provided and then change
nifi-solr-nar/pom.xml where it has:
```
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-standard-services-api-nar</artifactId>
<version>1.8.0-SNAPSHOT</version>
<type>nar</type>
</dependency>
```
To
```
<dependency>
<groupId>org.apache.nifi</groupId>
<artifactId>nifi-solr-client-api-nar</artifactId>
<version>1.8.0-SNAPSHOT</version>
<type>nar</type>
</dependency>
```
That should make it work correctly for both cases.
> Add SolrClientService
> ---------------------
>
> Key: NIFI-5224
> URL: https://issues.apache.org/jira/browse/NIFI-5224
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Johannes Peter
> Assignee: Mike Thomsen
> Priority: Major
>
> The Solr CRUD functions that are currently included in SolrUtils should be
> moved to a controller service.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
