Github user markap14 commented on the issue:

    https://github.com/apache/nifi/pull/3111
  
    @arkadius thanks for the contribution. I don't think this is the right 
approach, however, As-is, the code ensures that we don't hold any more than a 
set number of entries in the cache. The proposed change removes this 
limitation, which introduces a memory leak that can quickly cause a system to 
run out of memory if they are using an unbounded number of schemas (as can 
occur if a system is dynamically generating schemas).
    
    The synchronization here is limited to an extremely small scope. Can you 
explain how you arrived at the determination that the existing code is slow? 
What kind of performance are you seeing? What performance do you expect? What 
kind of difference do you see after applying this change?


---

Reply via email to