[
https://issues.apache.org/jira/browse/MINIFICPP-659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667811#comment-16667811
]
ASF GitHub Bot commented on MINIFICPP-659:
------------------------------------------
Github user arpadboda commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/430#discussion_r229112853
--- Diff: thirdparty/rocksdb/CMakeLists.txt ---
@@ -592,16 +592,16 @@ if(WIN32)
set(LIBS ${ROCKSDB_STATIC_LIB} ${THIRDPARTY_LIBS} ${SYSTEM_LIBS})
else()
set(SYSTEM_LIBS ${CMAKE_THREAD_LIBS_INIT})
- set(LIBS ${ROCKSDB_SHARED_LIB} ${THIRDPARTY_LIBS} ${SYSTEM_LIBS})
- add_library(${ROCKSDB_SHARED_LIB} SHARED ${SOURCES})
+ set(LIBS ${ROCKSDB_STATIC_LIB} ${THIRDPARTY_LIBS} ${SYSTEM_LIBS})
+ #add_library(${ROCKSDB_SHARED_LIB} SHARED ${SOURCES})
# target_link_libraries(${ROCKSDB_SHARED_LIB}
# ${THIRDPARTY_LIBS} ${SYSTEM_LIBS})
- set_target_properties(${ROCKSDB_SHARED_LIB} PROPERTIES
- LINKER_LANGUAGE CXX
- VERSION ${ROCKSDB_VERSION}
- SOVERSION ${ROCKSDB_VERSION_MAJOR}
- CXX_STANDARD 11
- OUTPUT_NAME "rocksdb")
+# set_target_properties(${ROCKSDB_SHARED_LIB} PROPERTIES
--- End diff --
Why commented?
If we comment it, even temporary, let's add some comment that justifies.
> Move CAPI code out of libminifi
> -------------------------------
>
> Key: MINIFICPP-659
> URL: https://issues.apache.org/jira/browse/MINIFICPP-659
> Project: NiFi MiNiFi C++
> Issue Type: Improvement
> Reporter: Mr TheSegfault
> Assignee: Mr TheSegfault
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
