[
https://issues.apache.org/jira/browse/NIFI-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16670424#comment-16670424
]
ASF GitHub Bot commented on NIFI-5771:
--------------------------------------
GitHub user markap14 opened a pull request:
https://github.com/apache/nifi/pull/3118
NIFI-5771: Ensure that we only increment claimant count for content c…
…laim if we have a FlowFile that references it
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markap14/nifi NIFI-5771
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3118.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3118
----
commit 2fbb61f852abd86a134916bd8b2f6fda5b187241
Author: Mark Payne <markap14@...>
Date: 2018-10-31T17:11:58Z
NIFI-5771: Ensure that we only increment claimant count for content claim
if we have a FlowFile that references it
----
> If 0-byte FlowFiles are load balanced, can result in content claim not being
> cleaned up
> ---------------------------------------------------------------------------------------
>
> Key: NIFI-5771
> URL: https://issues.apache.org/jira/browse/NIFI-5771
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
> Reporter: Mark Payne
> Assignee: Mark Payne
> Priority: Critical
> Fix For: 1.9.0
>
>
> To replicate, create two separate Flows:
> GenerateFlowFile (File Size 800 KB) -> UpdateAttribute [auto-terminate]
> GenerateFlowFile (FileSize 0 B) -> UpdateAttribute [auto-terminate]
> On the second one, that is generating 0-byte flowfiles, configure the
> Connection to Load Balance (Round Robin is easiest).
> Start both flows.
> After a minute or two, stop the GenerateFlowFile processors; let the
> flowfiles finish being processed by UpdateAttribute.
> Now, wait for the FlowFile Repository to checkpoint. At this point, the
> content claim should be cleaned up and delete/archive any content claims
> (with the exception of a few claims that are still 'writable'). However, some
> claims are still sticking around when they shouldn't.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
