[ 
https://issues.apache.org/jira/browse/NIFI-5777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674757#comment-16674757
 ] 

ASF GitHub Bot commented on NIFI-5777:
--------------------------------------

Github user kotarot commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3122#discussion_r230650492
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestLogMessage.java
 ---
    @@ -57,7 +57,7 @@ MockComponentLog getMockComponentLog() {
         public void before() throws InitializationException {
             testableLogMessage = new TestableLogMessage();
             runner = TestRunners.newTestRunner(testableLogMessage);
    -
    +        runner.setValidateExpressionUsage(false);
    --- End diff --
    
    @pvillard31 @ijokarumawak Thank you for your reviews.
    
    At first, the purpose of my PR was, to enable to pick up a Log Level from 
the pull-down list (as we can do it on the LogAttribute processor), so that I 
would like to make it easier for users (including NiFi beginners) to use this 
processor.
    
    As @ijokarumawak has suggested, should I fix it to be EL acceptable for 
flexible logging usages?


> Update the tag and the property of LogMessage
> ---------------------------------------------
>
>                 Key: NIFI-5777
>                 URL: https://issues.apache.org/jira/browse/NIFI-5777
>             Project: Apache NiFi
>          Issue Type: Improvement
>    Affects Versions: 1.8.0
>            Reporter: Kotaro Terada
>            Assignee: Kotaro Terada
>            Priority: Major
>
> There are a few points to update in {{LogMessage}}:
>  * The processor tags are a little bit strange. The current tags are 
> "attributes" and "logging". A tag "attributes" is not suitable for this 
> processor. I suggest just "logging" is enough.
>  * The property "Log Level" should be selected using a drop-down list (as it 
> is done in {{LogAttribute}}). Currently, the field is just a text box, and 
> users need to type a log level manually. If we set "expression language 
> supported" on the property, does it force to make the property become a text 
> field in the Web UI?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to