Github user colindean commented on a diff in the pull request:
https://github.com/apache/nifi/pull/3133#discussion_r230935621
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPool.java
---
@@ -164,6 +161,71 @@ public ValidationResult validate(final String subject,
final String input, final
.expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
.build();
+ public static final PropertyDescriptor MIN_IDLE = new
PropertyDescriptor.Builder()
+ .name("Minimum Idle Connections")
+ .description("The minimum number of connections that can
remain idle in the pool, without extra ones being " +
+ "created, or zero to create none.")
+ .defaultValue("0")
+ .required(true)
+ .addValidator(StandardValidators.INTEGER_VALIDATOR)
+ .sensitive(false)
+ .build();
+
+ public static final PropertyDescriptor MAX_IDLE = new
PropertyDescriptor.Builder()
+ .name("Max Idle Connections")
+ .description("The maximum number of connections that can
remain idle in the pool, without extra ones being " +
+ "released, or negative for no limit.")
+ .defaultValue("8")
--- End diff --
There are some defaults I could reference, e.g.
`org.apache.commons.pool2.impl.BaseObjectPoolConfig#DEFAULT_MIN_EVICTABLE_IDLE_TIME_MILLIS`
and `org.apache.commons.pool2.impl.GenericObjectPoolConfig#DEFAULT_MAX_IDLE`.
Should I instead reach into DBCP to get those?
---
