[
https://issues.apache.org/jira/browse/NIFI-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677186#comment-16677186
]
ASF GitHub Bot commented on NIFI-5795:
--------------------------------------
GitHub user luup2k opened a pull request:
https://github.com/apache/nifi/pull/3135
[NIFI-5795] RedisDistributedMapCacheClientService put missing option
https://issues.apache.org/jira/browse/NIFI-5795
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number
you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/luup2k/nifi patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3135
----
commit be39b647a0ad02c3c0c338fe11488d47497d702e
Author: luup2k <3969130+luup2k@...>
Date: 2018-11-06T19:05:23Z
NIFI-5795 RedisDistributedMapCacheClientService put missing option
https://issues.apache.org/jira/browse/NIFI-5795
----
> RedisDistributedMapCacheClientService put missing option
> --------------------------------------------------------
>
> Key: NIFI-5795
> URL: https://issues.apache.org/jira/browse/NIFI-5795
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.8.0
> Reporter: Alex
> Priority: Major
>
> When you select on *PutDistributedMapCache CACHE_UPDATE_STRATEGY =
> CACHE_UPDATE_REPLACE we execute "cache.put(cacheKey, cacheValue,
> keySerializer, valueSerializer);"*
> [LINK|https://github.com/apache/nifi/blob/ea9b0db2f620526c8dd0db595cf8b44c3ef835be/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDistributedMapCache.java#L202]
> If you use redis as backend service this jumps to:
> RedisDistributedMapCacheClientService.java ->
> redisConnection.set(kv.getKey(), kv.getValue(), Expiration.seconds(ttl),
> null);
> [LINK|https://github.com/apache/nifi/blob/ea9b0db2f620526c8dd0db595cf8b44c3ef835be/nifi-nar-bundles/nifi-redis-bundle/nifi-redis-extensions/src/main/java/org/apache/nifi/redis/service/RedisDistributedMapCacheClientService.java#L191]
> Calling to spring-data/redis/ library, but we have a bug putting null as
> Option parameter, causing an error "option cannot be null", because according
> to library: "{{option}} - must not be null." [Library
> Link|https://docs.spring.io/spring-data/redis/docs/current/api/org/springframework/data/redis/connection/RedisStringCommands.html#set-byte:A-byte:A-org.springframework.data.redis.core.types.Expiration-org.springframework.data.redis.connection.RedisStringCommands.SetOption-]
> If we want to update strategy we should use:
> [{{RedisStringCommands.SetOption.upsert()}}|https://docs.spring.io/spring-data/redis/docs/current/api/org/springframework/data/redis/connection/RedisStringCommands.SetOption.html#upsert--]
>
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
