Github user ijokarumawak commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3113#discussion_r231743426
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutSQL.java
 ---
    @@ -134,6 +134,14 @@
                 
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
                 .build();
     
    +    static final PropertyDescriptor AUTO_COMMIT = new 
PropertyDescriptor.Builder()
    +            .name("database-session-autocommit")
    +            .displayName("Database session autocommit value")
    +            .description("The autocommit mode to set on the database 
connection being used.")
    +            .allowableValues("true", "false")
    +            .defaultValue("false")
    +            .build();
    --- End diff --
    
    @viswaug Thanks for the snowflake doc link and explanation. Look forward to 
see new commits for further review. In order to update your PR, you just need 
to:
    1. Make code changes
    2. Add the changed files for a commit: `git add <file>` or `git add -A` 
(all changed files)
    3. Commit with some comments: `git commit`, this makes a commit to your 
local branch
    4. Push the commit to your remote branch: `git push origin 
configurable_autocommit_putsql`. This command adds the new commit to this PR.


---

Reply via email to